Support on_unused_input for string parameter names in eval
#1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
reviewed
Nov 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1085 +/- ##
=======================================
Coverage 82.10% 82.10%
=======================================
Files 183 183
Lines 47932 47934 +2
Branches 8634 8635 +1
=======================================
+ Hits 39355 39357 +2
Misses 6410 6410
Partials 2167 2167
|
ricardoV94
reviewed
Nov 12, 2024
|
Thanks for supplying a better workaround for my use case in #1084 I'll leave this PR open though because this would still be a useful feature! I've implemented the change you requested. |
ricardoV94
approved these changes
Nov 12, 2024
ricardoV94
changed the title
on_unused_input="warn" for string parameter names in evalon_unused_input for string parameter names in eval
|
Thanks @tvwenger, changes look good |
ricardoV94
changed the title
on_unused_input for string parameter names in evalon_unused_input for string parameter names in eval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the feature requested in #1084
Related Issue
on_unused_input="ignore"for string keys ineval#1084Checklist
Type of change
📚 Documentation preview 📚: https://pytensor--1085.org.readthedocs.build/en/1085/